grpcio: improve client interceptors #14831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srittau one more for you :) |
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Oct 7, 2025
There was a problem hiding this comment.
A note on the tests: We don't run the tests, we only run type checkers against them, which is fairly expensive. Which is why we only use tests for weird corner cases and especially complex type annotations.
While the previous annotations were wrong, the new annotations aren't particular complex, so I don't think we need tests. The comments before the abstract methods should make the intent of the generics clear.
|
Fair point, I removed the new tests and expanded the comments to clarify the invariant that the types need to satisfy. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #14785
ClientInterceptors should not be generic over request/response themselves, but rather should have generic methods: a given instance of this should be able to intercept any call, and so should have a generic method over all request/continuation types rather than the instance being specialized itself.
I also fixed the continuation/return types on the client interceptors which were incorrect:
The new tests demonstrate the correct usage.
Fixes: #14641